Open
Conversation
Owner
|
I don't do much perl nowadays, but I remember back in my head that the given-when construct has some strange properties. So a rewrite using plain if-elsif would probably be the cleanest solution. I would be happy to merge a change eliminating the given-when statements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On perl v5.36 I ran into a bug that took me a while to track down. The
given()construct erases its argument after mixing theifstatements with thewhen()statements.I don't expect you want to accept this pull request as-is (there's probably a more elegant way to do it), but I did want to send it to you in case you or other people got confused why list commands like
subscribe foofail.