Make TCNPlus consistent, create the right config format, deleting assertion#1
Open
BiqianCheng wants to merge 13 commits intomainfrom
Open
Make TCNPlus consistent, create the right config format, deleting assertion#1BiqianCheng wants to merge 13 commits intomainfrom
BiqianCheng wants to merge 13 commits intomainfrom
Conversation
BiqianCheng
commented
Oct 24, 2023
- Ignore the changes of num_batches, which is somehow included in this commit
- Missing batch normalization in the FCNPlus json.file
- Ignore the modification of rnn.json
- ATTENTION starts from here In the src/models/get_model.py, the model name is selected to be "FCN" however it later refers to FCNPlus's configurations. To make this consistent, I request to change them all into FCNPlus.
- #25 The right configure format has been corrected. Otherwise, it will run into the "all strings cannot be converted to the right type" error.
- src/models/tsai/tsai/models/FCNPlus.py, the assertion doesn't make sense since layers=[128, 256, 128], kss=[7, 5, 3] in default. We will never be able to pass the assertion. I commented it out so it is possible to try the FCNPlus model and see its performance.
… channels for debugging TSInterpret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.