Fix esi on noncached pages and when Content type is application/json#24
Open
albertdahlin wants to merge 3 commits intomadepeople:masterfrom
Open
Fix esi on noncached pages and when Content type is application/json#24albertdahlin wants to merge 3 commits intomadepeople:masterfrom
albertdahlin wants to merge 3 commits intomadepeople:masterfrom
Conversation
Contributor
|
A bunch of changes have been made to the varnish stuff lately, i would suggest merging master into your fork andto see if the problem persists. Regarding ESI, the syntax 0x2 allows for escaped ESI attributes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch disables ESI processing on non cached pages (ttl = 0) and responses with Content-Type application/json.
This also fixes an issue with session messages disappearing on non cached pages. (eg account/login)
If you enter the wrong password on account/login the message you don't get any message due to this line. It removes all messages from the session and when madecache/varnish/messages tries to render the message block there is nothing left.