Skip to content

Conversation

@tekkub
Copy link

@tekkub tekkub commented Jul 11, 2016

👋 @maddox

So I added docker support for you. I included an example docker-compose.yml file too. If you end up pushing an image up to docker hub, you'll want to change the build: . line to image: maddox/dasher.

One caveat: since the docker image runs as root, I skipped your setup script and instead ran the button finder directly:

docker run -it --rm --privileged --net=host tekkub/dasher \
  node node_modules/node-dash-button/bin/findbutton

@maddox
Copy link
Owner

maddox commented Aug 18, 2016

I know literally nothing about Docker, lol. So I guess this is all good? @jnewland?

Also, I just created a docker repo here: https://hub.docker.com/r/jonmaddox/dasher/

Could we point it at this? This pull on another of my repos has something regarding this.

@americanwookie
Copy link

I was thinking about dockerizing this, and was excited to see this PR. Is there anything that can be done to help get it into dockerhub?

dasher:
build: .
network_mode: host
privileged: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is --privileged really necessary?
I'm running clemenstyp/dasher-docker on my system without it and it is working fine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are indeed correct!

@tekkub
Copy link
Author

tekkub commented Dec 7, 2016

@maddox I have no experience with docker hub myself, I've only really been using docker for my own private things. ¯\_(ツ)_/¯

@americanwookie
Copy link

I have dockerhub experience! :) It's really easy to link a dockerhub repo with a github repo. I did it myself as a proof of concept with this github repo: https://hub.docker.com/r/americanwookie/rpi3-distribution/. Docker makes it really easy if your comfortable with linking your dockerhub account to your github account and giving docker several permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants