#7 Make test app and installation of headers optional#12
Open
Mr-Question wants to merge 1 commit intomaddouri:masterfrom
Open
#7 Make test app and installation of headers optional#12Mr-Question wants to merge 1 commit intomaddouri:masterfrom
Mr-Question wants to merge 1 commit intomaddouri:masterfrom
Conversation
Added CMake variables DYNALO_INSTALL_API and DYNALO_BUILD_TEST to enable/disable usage of test app and installation of auxiliary files.
|
Line 21 in 27859bc An alternative approach I have seen used elsewhere is to test if this project is being included as a sub-project and enabling/disabling install based on this. Something like: if(NOT DEFINED PROJECT_NAME)
set(MY_PROJECT_IS_A_SUBPROJECT OFF)
else()
set(MY_PROJECT_IS_A_SUBPROJECT ON)
endif()
project(my-project VERSION 0.0.0 LANGUAGES CXX)
if (NOT MY_PROJECT_IS_A_SUBPROJECT)
install(...)
endif()I think this is more convenient as it doesn't require explicitly enabling installation when you want it, which looks like what someone would have to do with the changes you've proposed. Another way you can avoid installing your dependencies when you use them as a subproject is to use CMake's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CMake variables DYNALO_INSTALL_API and DYNALO_BUILD_TEST to
enable/disable usage of test app and installation of auxiliary files.