-
Notifications
You must be signed in to change notification settings - Fork 38
Include timestamp in history CLI #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mmx-docs canceled.
|
✅ Deploy Preview for explore-mmx canceled.
|
|
I didn't add |
|
Changes Rev02:
Keeping to semantic/logic from existing work. PS: Tell if want other prefix label than |
|
Well maybe it makes sense to show the date and time in human readable format? See |
|
Not against it. My thought was to limit changes as much as possible (for now). Get data needed for temporary script to be able to transform to CSV for spreadsheet imports (i.e., Excel). Nearly finished with a bash script that uses From
Output from
Taking UnixTS through Meant as a temporary script solution I host on my GitHub, and point people to. Ideally (future), should be a Open to any direction, that best fits existing framework. |
|
Hmm yes, it would be better to implement it all in C++, this way your script doesn't break if we change format of I'll do it real quick. |
|
@voidxno check latest master |
|
Thx Max 👍 Will give it a run in a few hours and report back. |
|
@madMAx43v3r Output is nearly perfect (don't need separate script anymore) :-) One small CSV edge case (no showstopper):
Basically:
Not very important. Still going to spreadsheet import ok'ish. Just that memo text above will split into two columns. |
|
Ok should be fixed |
|
Thx again. I'll do a last test. Then Close this PR with "redundant" :-) ( + tip people on Discord that functionality exists ) |
|
Closing PR (redundant). Achieved with new CLI's (as of latest master
|
PR for including timestamp in
mmx node historyCLI exportGoal: Make it possible to export rewards with timestamp (tax reporting)
Changes:
TS(time_stamp)afterTX(txid), same styleTX(to existing(txid), if 'nft_binary' (align style)Questions:
PS: If merged, probably going to create a script, outside PR/mmx-node, that reformats output (i.e., only rewards, transform timestamp, CSV).