Fix search artist score overwriting title score #24
Open
jmeosbn wants to merge 1 commit intomacr0dev:masterfrom
Open
Fix search artist score overwriting title score #24jmeosbn wants to merge 1 commit intomacr0dev:masterfrom
jmeosbn wants to merge 1 commit intomacr0dev:masterfrom
Conversation
- replace using simple average with equal weighting
jmeosbn
changed the title
jmeosbn
force-pushed
the
pull-requests/search-scoring
branch
from
d10acb4 to
b633edc
Compare
jmeosbn
force-pushed
the
pull-requests/search-scoring
branch
4 times, most recently
from
33e6502 to
7470ace
Compare
jmeosbn
force-pushed
the
pull-requests/search-scoring
branch
from
7470ace to
fe4e162
Compare
jmeosbn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for the search score of the artist overwriting that of the actual title - then, a change to use a length based ratio instead of straight Levenshtein distance else completely wrong titles can still score 97% or so if short and with matching artist.
note: pruned back additional commits as unable to keep stale PRs from conflicting