docker-machine tweaks in support of PR #13 by dx9 · Pull Request #14 · machine-drivers/docker-machine-driver-hyperkit

dx9 · 2019-09-24T18:40:05Z

Depends on #13

Tested against docker-machine.

Search for boot files using patterns instead of hard coded paths. Similar to the docker-machine-driver-xhyve approach. Signed-off-by: John Coyle <dx9err@gmail.com>

Only set CPU or memory values when requested value is greater than the default. Signed-off-by: John Coyle <dx9err@gmail.com>

Hyperkit uses this UUID to assign a MAC address that the driver is expecting. The driver searches for this MAC address in the DHCP lease file to resolve the machine. Using a UUID based on machine name minimizes entries in the DHCP lease file. It also provides IP address consistency while the DHCP lease is valid. Signed-off-by: John Coyle <dx9err@gmail.com>

Set a default disk size. Move init of BaseDriver.SSHUser to Create() to avoid overwrite. Signed-off-by: John Coyle <dx9err@gmail.com>

…-count, memory-size). Signed-off-by: John Coyle <dx9err@gmail.com>

sharifelgamal · 2019-10-16T21:52:23Z

This has been tested and works with minikube as well. I'm would be happy for this to get merged and to abandon my PR.

tstromberg · 2019-12-16T19:29:07Z

Can we merge this?

ermik

This PR is really important to merge in. Without these changes it is impossible to use the project. cc @r2d4

ermik · 2020-02-19T22:04:21Z

pkg/hyperkit/driver.go

+	if d.CPU > defaultCPUs {
+		h.CPUs = d.CPU
+	}
+	if d.Memory > defaultMemory {


Suggested change

if d.Memory > defaultMemory {

if d.Memory > 0 {

// 0 or minMemory, if known

While unlikely and against better judgement, user should be allowed to lower the request for memory. Same could be done for CPU count, if fractions of CPU are supported by hyperkit.

maciejzj · 2020-09-27T12:39:20Z

Any chance this will be merged?

zazula · 2020-10-04T15:55:52Z

Can verify that this now makes docker-machine create --driver hyperkit usable on MacOS :)

spiilmusic · 2020-10-23T08:54:22Z

Hi @zazula
Did you manage to start some container in hyperkit docker-machine with this changes?

I got the error:

docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"rootfs_linux.go:109: jailing process inside rootfs caused \\\"pivot_root invalid argument\\\"\"": unknown.

zazula · 2020-10-23T10:22:25Z

Hi @zazula
Did you manage to start some container in hyperkit docker-machine with this changes?

I got the error:

docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"rootfs_linux.go:109: jailing process inside rootfs caused \\\"pivot_root invalid argument\\\"\"": unknown.

Try adding this to your docker-machine command:

--engine-env DOCKER_RAMDISK=true

spiilmusic · 2020-10-23T10:47:22Z

Try adding this to your docker-machine command:

--engine-env DOCKER_RAMDISK=true

Strange, but with this env I even can't pull image, btw it works normally on vbox machine:

docker pull alpine                                                                                        
Using default tag: latest
Error response from daemon: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

zazula · 2020-10-25T23:30:41Z

Try adding this to your docker-machine command:
--engine-env DOCKER_RAMDISK=true

Strange, but with this env I even can't pull image, btw it works normally on vbox machine:
docker pull alpine                                                                                        
Using default tag: latest
Error response from daemon: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

Try with my clone of the repo here:

https://github.com/zazula/docker-machine-driver-hyperkit

brew install golang dep
go get github.com/zazula/docker-machine-driver-hyperkit
cd ~/go/src/github.com/zazula/docker-machine-driver-hyperkit
make build

docker-machine -D create --driver hyperkit --engine-env DOCKER_RAMDISK=true --hyperkit-cpu-count 12 --hyperkit-disk-size 40960 --hyperkit-memory-size 16192  local
[...]

then

$eval $(docker-machine env local)

$docker pull alpine
Using default tag: latest
latest: Pulling from library/alpine
188c0c94c7c5: Pull complete 
Digest: sha256:c0e9560cda118f9ec63ddefb4a173a2b2a0347082d7dff7dc14272e7841a5b5a
Status: Downloaded newer image for alpine:latest
docker.io/library/alpine:latest

$ docker run -it alpine sh
/ # ls
bin    etc    lib    mnt    proc   run    srv    tmp    var
dev    home   media  opt    root   sbin   sys    usr
/ # exit

zazula · 2020-10-25T23:34:55Z

Also, make sure your hyperkit binary is setuid root

spiilmusic · 2020-10-26T16:03:25Z

Also, make sure your hyperkit binary is setuid root

It looks like it was trouble with my host /etc/resolv.conf, so docker-machine couldn't access internet. At this time I was able to run containers 🎉
One note: I had to run make build with CGO_ENABLED=1 due to an error: Error creating machine: Error in driver during machine creation: getting MAC address from UUID: Function not supported on CGO_ENABLED=0 binaries

Anyway thx! Now I got significant increase mount host filesystem performance 🥳

zazula · 2020-10-26T16:48:47Z

Also, make sure your hyperkit binary is setuid root

It looks like it was trouble with my host /etc/resolv.conf, so docker-machine couldn't access internet. At this time I was able to run containers 🎉
One note: I had to run make build with CGO_ENABLED=1 due to an error: Error creating machine: Error in driver during machine creation: getting MAC address from UUID: Function not supported on CGO_ENABLED=0 binaries

Anyway thx! Now I got significant increase mount host filesystem performance 🥳

Great! I don't recall doing anything with the CGO_ENABLED flag but glad you have it working.

I'm working on some fixes for NFS mounts and exposing some of the NFS config flags as --hyperkit-nfs-xxx

JesusTheHun · 2020-11-30T17:42:04Z

hi, can someone provide an update on this ?

sharifelgamal and others added 8 commits September 19, 2019 10:17

Moving minikube hyperkit changes upstream

01bd201

remove minikube import

244411c

add missing files

18a3d7e

Support various ISO kernel boot file layouts.

d6466b0

Search for boot files using patterns instead of hard coded paths. Similar to the docker-machine-driver-xhyve approach. Signed-off-by: John Coyle <dx9err@gmail.com>

Don't set hyperkit package CPU and memory defaults with zero values.

2258b94

Only set CPU or memory values when requested value is greater than the default. Signed-off-by: John Coyle <dx9err@gmail.com>

Fix SSH using docker-machine

0109dc5

Set a default disk size. Move init of BaseDriver.SSHUser to Create() to avoid overwrite. Signed-off-by: John Coyle <dx9err@gmail.com>

Add some docker-machine config flags (boot2docker-url, disk-size, cpu…

46602b1

…-count, memory-size). Signed-off-by: John Coyle <dx9err@gmail.com>

ermik suggested changes Feb 19, 2020

View reviewed changes

This was referenced Aug 7, 2020

Error in driver during machine creation #16

Open

Could not convert the UUID to MAC address machine-drivers/docker-machine-driver-xhyve#230

Open

	if d.Memory > defaultMemory {
	if d.Memory > 0 {
	// 0 or minMemory, if known

Conversation

dx9 commented Sep 24, 2019

Uh oh!

sharifelgamal commented Oct 16, 2019

Uh oh!

tstromberg commented Dec 16, 2019

Uh oh!

ermik left a comment

Choose a reason for hiding this comment

Uh oh!

ermik Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maciejzj commented Sep 27, 2020

Uh oh!

zazula commented Oct 4, 2020

Uh oh!

spiilmusic commented Oct 23, 2020

Uh oh!

zazula commented Oct 23, 2020

Uh oh!

spiilmusic commented Oct 23, 2020

Uh oh!

zazula commented Oct 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zazula commented Oct 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spiilmusic commented Oct 26, 2020

Uh oh!

zazula commented Oct 26, 2020

Uh oh!

JesusTheHun commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ermik Feb 19, 2020 •

edited

Loading

zazula commented Oct 25, 2020 •

edited

Loading

zazula commented Oct 25, 2020 •

edited

Loading