Open
Conversation
mfkasim1
suggested changes
Jun 21, 2024
mfkasim1
suggested changes
Jul 4, 2024
mfkasim1
suggested changes
Jul 12, 2024
deer/fsolve_ivp.py
Outdated
Comment on lines
190
to
196
| def success_fn(carry, i): | ||
| yi, _ = carry | ||
| xi = xinp[i-1] | ||
| dx = xinp[i] - xinp[i-1] | ||
| dt = tpts[i] - tpts[i-1] | ||
| yn, success = self.ode_step(func, yi, xi, dt, dx, params) | ||
| return yn, success |
Contributor
There was a problem hiding this comment.
Seems like xinp and tpts variables are coming from outside this function and that would make this function unpure. JAX has a strong obsession with pure function (see this for example), so can you make it a pure function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #18