Skip to content

Conversation

@amkayondo
Copy link

What the PR does

amkayondo and others added 2 commits November 25, 2019 22:42
remove unnecessary details
@dusan-turajlic
Copy link

Wouldn't the more correct way to do this be to actually change the method names and create a new version tag in git for this project? That way it wouldn't need to maintain old UNSAFE_ methods but still have a version that can be used if your project is running an old version of RN

@amkayondo
Copy link
Author

amkayondo commented Jan 28, 2020

am using current react native version, so would you update the names because I love using this package😊

@dusan-turajlic
Copy link

I'm not a maintainer of this project I'm actually quite new to react-native. I was just wondering if there was a reason for just adding the UNSAFE_ instead of updating the class to have new methods. My comment was not a suggestion or advice it was just a question because I would like to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants