Skip to content

Avoid showing unsupported device UI if already running required major OS #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MagerValp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid showing unsupported device UI if already running required major OS #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Nudge/UI/Main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,14 @@ class AppDelegate: NSObject, NSApplicationDelegate {
supportedDevice in Globals.hardwareModelIDs.contains { $0.uppercased() == supportedDevice.uppercased() } }
)
LogManager.notice("Assessed Model ID found in SOFA Entry: \(deviceMatchFound)", logger: sofaLog)
nudgePrimaryState.deviceSupportedByOSVersion = deviceMatchFound
let majorRequiredVersion = VersionManager.getMajorRequiredNudgeOSVersion()
let currentMajorVersion = VersionManager.getMajorOSVersion()
if !deviceMatchFound && (majorRequiredVersion == currentMajorVersion) {
LogManager.warning("Assessed Model ID not found in SOFA Entry, but device is already running required major OS version. Disregarding unsupported UI.", logger: sofaLog)
nudgePrimaryState.deviceSupportedByOSVersion = true
} else {
nudgePrimaryState.deviceSupportedByOSVersion = deviceMatchFound
}
}
}
foundMatch = true
Expand Down