Small change for config_dir#4
Open
Whytey wants to merge 18 commits intomaartendamen:masterfrom
Whytey:master
Open
Small change for config_dir#4Whytey wants to merge 18 commits intomaartendamen:masterfrom Whytey:master
Whytey wants to merge 18 commits intomaartendamen:masterfrom
Whytey:master
Conversation
added 18 commits
September 10, 2011 00:33
…grades of packages
…tra debug data when can't load plugin pages.py file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Maarten,
Bahh, seems I haven't quite got the hang of this git thing yet.
Anyway, my latest commit, cc74952, has a minor change to the houseagent/init.py to expose not just the config_file but also the config_dir, since plugins will need to know where they can load their config from (i.e. the zwave plugin needs to import houseagent.config_dir and then locate its config file at os.path.join(config_dir, 'zwave', 'zwave.conf')).
Can you confirm what I have done is OK? Is it possible for you to pull in just that one change?
Cheers,
Whytey