Implementation of Input wrapper for Iterator types#49
Open
Conversation
m4rw3r
force-pushed
the
feature/input_trait
branch
from
607b4a3 to
f037f09
Compare
m4rw3r
force-pushed
the
feature/iterator_input
branch
from
281ba9e to
d180f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue with this is how to handle backtracking. A simple
VecDequewon't do since we cannot mark and track old positions while still keeping the new data. Most likely something withRcis required to keep track of positions into a common buffer which is append only and will only drop items off the front if those items are no longer used (ie. no cursor pointing to them).