Conversation
…treams Variant HLS streams always have 0 registered clients (clients register with the parent stream), so they get recycled on every playlist refresh. This reset total_bytes_served and total_segments_served to 0, causing the stream monitor to show fluctuating data transfer values instead of cumulative totals.
Member
|
Thank you! I'll review and merge shortly... |
Make sure restore block is guarded by recycle state rather than non-zero counters. Added assert recycled_created_at is not None to narrow the type and satisfy the type checker, since the field is guaranteed non-None when was_recycled is True. Add tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
total_bytes_served,total_segments_served, andcreated_atwhen recycling orphaned streams inget_or_create_stream()Safety
The preserved fields are purely stats counters — never used in pooling, failover, cleanup, or routing logic. All operational state (failover, error counts, circuit-breaker, URLs) still resets as before.