Skip to content

fix: Remove scroll-to-top on table pagination page change#889

Merged
sparkison merged 1 commit intom3ue:devfrom
Warbs816:fix/table-pagination-scroll-to-top
Mar 28, 2026
Merged

fix: Remove scroll-to-top on table pagination page change#889
sparkison merged 1 commit intom3ue:devfrom
Warbs816:fix/table-pagination-scroll-to-top

Conversation

@Warbs816
Copy link
Copy Markdown
Contributor

@Warbs816 Warbs816 commented Mar 28, 2026

Summary

  • Removes setPage() overrides in ListChannels and ListVod that dispatched a scroll-to-top event on every page change, causing the browser to smooth-scroll to the top
  • Removes the now-unused global scroll-to-top JS event listener from AppServiceProvider and the orphaned HtmlString import

Test plan

  • Navigate to Channels list, scroll down, change page — scroll position should be preserved
  • Navigate to VOD list, scroll down, change page — scroll position should be preserved
  • Confirm other tables (Series, Groups, Playlists, etc.) still paginate normally

@Warbs816 Warbs816 marked this pull request as ready for review March 28, 2026 15:25
@sparkison
Copy link
Copy Markdown
Member

Good call! This was from a while back before the tables had a max height and fixed header, but it doesn't make much sense now 😉

@sparkison sparkison merged commit 185166c into m3ue:dev Mar 28, 2026
4 checks passed
@Warbs816 Warbs816 deleted the fix/table-pagination-scroll-to-top branch March 28, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants