Open
Conversation
Add optional yield field (quantity + unit) to Recipe mongoose model with validation. Extend RecipeTC with a resolved yield.unit field so GraphQL queries can fetch the full Unit object. Include migration script to set yield: null on existing documents.
Address roborev finding: replace iterate-then-update pattern with a single updateMany call, which is more efficient on large collections.
Add yield { quantity, unit { ...UnitFields } } to RECIPE_FIELDS_FULL
fragment. Export scaleQuantity helper from quantity.ts for use in the
yield view component.
Address roborev finding: return original quantity unchanged when origServings is 0 to prevent division-by-zero errors.
Add YieldSlice Zustand store, EditableYield (Mantine) component for edit flow, Yield (Mantine) view component with scaling support, and wire everything through IngredientsTabLayout, SubmitButton, and EditRecipe page loader.
…tButton - Wrap fraction() calls in Yield.tsx with try/catch to handle invalid inputs - Include sign property (.s) in fraction numeric calculation for correctness - Add VALID_NUMBER_REGEX validation for yield quantity in SubmitButton validate()
- Fix missing return before drop() in Mongoose afterEach - Rename misleading scaleQuantity test, add actual fraction result case - Add range + zero origServings edge case test for scaleQuantity - Add integration test for unit-without-quantity edge case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.