Skip to content

feat: remove constraints from clones #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anatawa12 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: remove constraints from clones #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Runtime/Scripts/LyumaAv3Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,11 +434,10 @@ public string GetTypeString()
};

public static readonly Type[] MirrorCloneComponentBlacklist = new Type[] {
typeof(Camera), typeof(FlareLayer), typeof(AudioSource), typeof(Rigidbody), typeof(Joint)
typeof(Camera), typeof(FlareLayer), typeof(AudioSource), typeof(Rigidbody), typeof(Joint), typeof(IConstraint),
};
public static readonly Type[] ShadowCloneComponentBlacklist = new Type[] {
typeof(Camera), typeof(FlareLayer), typeof(AudioSource), typeof(Light), typeof(ParticleSystemRenderer), typeof(Rigidbody), typeof(Joint)

typeof(Camera), typeof(FlareLayer), typeof(AudioSource), typeof(Light), typeof(ParticleSystemRenderer), typeof(Rigidbody), typeof(Joint), typeof(IConstraint),
Copy link
Collaborator Author

@anatawa12 anatawa12 Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about shadow clone bit I assumed it's similar to mirror clone so I added constraint to this blacklist. is this correct?

};
public static readonly HashSet<string> CloneStringComponentBlacklist = new HashSet<string>() { "DynamicBone", "VRCContact", "VRCPhysBone", "VRCSpatialAudioSource" };

Expand Down