Handle WEBGL_draw_buffers availability upfront #2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!gl.getExtension("WEBGL_draw_buffers")) { | ||
| console.warn("WEBGL_draw_buffers extension unavailable; rendering will fail."); | ||
| if (msg) { | ||
| msg.innerText = "WEBGL_draw_buffers is required for SEC3DEMO."; | ||
| } | ||
| return; |
There was a problem hiding this comment.
The new WEBGL_draw_buffers guard in setupScene returns early when the extension is disabled, but main continues to call setKeyInputs, SEC3.renderer.init(), etc. without checking that initialization succeeded. In environments without the extension (the case this code targets), scene, interactor, and related globals are never created, so downstream calls will throw (e.g., interactor.onKeyDown in setKeyInputs) instead of failing fast. Consider surfacing the failure to main or skipping the rest of initialization when the extension check fails.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task