Use sampling rules configured in AWS X-Ray#21
Open
legoscia wants to merge 5 commits intolyokato:developfrom
Open
Use sampling rules configured in AWS X-Ray#21legoscia wants to merge 5 commits intolyokato:developfrom
legoscia wants to merge 5 commits intolyokato:developfrom
Conversation
If configured to do so, fetch sampling rules from AWS X-Ray, and apply them to new traces.
Let Mix figure out remaining dependencies.
This can happen if we use aws_ex_ray_ex_aws to hook into ExAws calls, and an application that is being started before aws_ex_ray makes an ExAws call during its startup. Let's handle that by ignoring such requests.
Make it easier to see the current rules.
The tests assume that the sampling rate is zero.
legoscia
force-pushed
the
online-rules
branch
from
08cb89f to
87afbf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the sampling rules module configurable, and add an additional option next to the simple sample rate: apply the rules configured in AWS X-Ray. This means that the rules can be updated without having to touch any application - the applications will fetch and apply the updated rules automatically.