feat: network ip detect and install for physical device development #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr improves on current app build flow with instead of using hardcoded 10.0.2.2 to instead prefer device network address so that if one wants to instead use physical device for development they can without issue.
To make stuff easier i have added android script as well as ios script that injects the network ip in the build cli command.
note the default fallback is 10.0.2.2 for android and localhost for ios so if thy dont want to rely on script,
they can go into android / apple folder and run the build script manually like how we are doing currently.
it works flawlessly on android as it auto detects adb device and install on it.
for ios i have added a xcrun script with help of ai but i cannot test it , so testing on ios simulator is needed.