feat: template based installer + tailwind option for cli + git init option for cli #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@okwasniewski @szymonrybczak mind taking a look at this |
| import fs from 'fs-extra'; | ||
| import path from 'path'; | ||
|
|
||
| export async function setupTailwind(targetPath: string): Promise<void> { |
Collaborator
There was a problem hiding this comment.
nit: can we delete the comments, function names are pretty self-explanatory already
| } | ||
|
|
||
| async function updateAppCSSForTailwind(targetPath: string): Promise<void> { | ||
| const appCSSContent = `@tailwind base; |
Collaborator
There was a problem hiding this comment.
let's leave a comment or let's open an issue to properly implement templates where each template which be used based on the option because it's much harder to maintain this kind flow that is added here.
HimanshuKumarDutt094
changed the title
Author
|
@szymonrybczak i added template based installer using github. sparse checkout, removed the copy-templates logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds tailwind setup following official docs lynx tailwind setup
i have a single util file that takes in all the folders needed for scaffold and copies them into a temp folder and then inside the project (perf is decent).
for tailwind i have 4 files that overwrites the base react but if needed we can make it a standalone template so we just either copy react or react-tailwind template.
This way we dont have to publish the templates to other sources.