[Feature Request] Automatic Subscriptions #1354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
reviewed
Jan 30, 2019
Contributor
lodoyun
left a comment
lodoyun
left a comment
There was a problem hiding this comment.
Looks good to me.
I assume updateConfiguration would still have to be made individually for each stream, which is fine for me. We can think about a bulk update in the future.
|
|
||
| ### Changes in ErizoController | ||
|
|
||
| It handles requests to subscribe with selectors with the AutoSubscriptionHandler. AutoSubscriptionHandler will perform subscribe/unsubscribe actions based on the given selectors. |
Contributor
There was a problem hiding this comment.
I think I prefer AutoSubscriptionManager since it does not sound like a handler to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a feature request to be discussed and that could be used during its development. The idea is to have a mechanism to subscribe automatically to newly published streams. It could eventually help reducing subscription times to a minimum while reducing complexity in cases with many streams.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.