modules: fix cross-compilation #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add -L$(libdir) to AM_LDFLAGS [Retrieved from: https://git.buildroot.net/buildroot/tree/package/libfm/0001-modules-fix-cross-compilation.patch] Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Member
|
This change may cause problems with non-standard $(libdir), see 362d192, or you think it was an old issue of libtool which is fixed nowadays? |
Author
|
I'll try to update the PR to drop |
Member
|
I believe you should simply add appropriate --libdir to your configure call for your cross-compiling recipe, the same way as it is usually done for cross-compiling everywhere. |
Member
|
Although it might be also possible that libtool issue is fixed, as I said, thus that line might be removed as you proposed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add -L$(libdir) to AM_LDFLAGS
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/libfm/0001-modules-fix-cross-compilation.patch]
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com