Re-enable LINSTOR tests

[bensmrs]

Closes: #2409

LINSTOR 1.32.3 has landed on LINBIT’s ppa

[stgraber]

I've retried the test to see if it's just racy, but we got:

 + timeout --foreground 120 /home/runner/go/bin/incus storage volume copy incustest-fpxY8q6ip-linstor/vol1/snap0 incustest-fpxY8q6ip-linstor1/vol3 --verbose
Error: Create custom volume from copy failed: [Could not delete temporary resource definition: Message: 'Resource 'incus-volume-fc9c5ff363ed460da96d7db22af5eb7a' on node 'local' is still in use.'; Cause: 'Resource is mounted/in use.'; Details: 'Resource definition: incus-volume-fc9c5ff363ed460da96d7db22af5eb7a'; Correction: 'Un-mount resource 'incus-volume-fc9c5ff363ed460da96d7db22af5eb7a' on the node 'local'.'; Reports: '[68ECCC82-00000-000000]']

[bensmrs]

I've retried the test to see if it's just racy

Yeah good call.

I should have time for this tomorrow or the day after.

[stgraber]

The retry gave:

+ incus storage volume copy incustest-7FUwmLDQw-linstor/vol1/snap0 incustest-7FUwmLDQw-linstor1/vol3
+ timeout --foreground 120 /home/runner/go/bin/incus storage volume copy incustest-7FUwmLDQw-linstor/vol1/snap0 incustest-7FUwmLDQw-linstor1/vol3 --verbose
Error: Create custom volume from copy failed: [Could not delete temporary resource definition: Message: 'Resource 'incus-volume-b93f06bf91324fc1b49abfc998a7f33a' on node 'local' is still in use.'; Cause: 'Resource is mounted/in use.'; Details: 'Resource definition: incus-volume-b93f06bf91324fc1b49abfc998a7f33a'; Correction: 'Un-mount resource 'incus-volume-b93f06bf91324fc1b49abfc998a7f33a' on the node 'local'.'; Reports: '[68ED3ADA-00000-000000]']

So looks like it's not a race. I've retried it one more time just in case, but I suspect we'll need to actually look into this one.

[bensmrs]

The last one gives yet another error…

[stgraber]

Ah yeah, we got:

+ timeout --foreground 120 /home/runner/go/bin/incus storage delete incustest-heXX61xjx-pool --verbose
Error: Could not delete Linstor resource group : Message: 'Cannot delete resource group 'incustest-heXX61xjx-pool' because it has existing resource definitions.'; Details: 'Resource group: incustest-heXX61xjx-pool'

Re-tried again to see if we're back to the failure we had the other two times.

[bensmrs]

You see, no problem at all :)
That’ll be fun to debug…

[stgraber]

Oh, great... Yeah, that will be fun...
I do remember the Linstor tests being rather racy in the past though I don't recall exactly where they used to fail.

Anyway, we can merge this one since it at least passes "sometimes", then can work on sorting out the race conditions...

[bensmrs]

I’m running tests in bensmrs#1 and will try i) to add a few sleeps before the racy lines (if they can clearly be identified) then ii) try to actually remedy it.