Conversation
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
Just some "stylistic" comments
There was a problem hiding this comment.
I would suggest having a README that is more similar to other READMEs we have in other top level folders (e.g here or here etc.). Though since this does have some additional information about the actual interfaces we could do a merge of the two styles but I would still prefer to have this table towards the top of the README so that user can quickly jump to the example that suits them.
There was a problem hiding this comment.
Since this PR creates a new top-level directory we need to also add it to the first page README here
| @@ -0,0 +1,7 @@ | |||
| hidapi | |||
| git+https://github.com/luxonis/rp2040_u2if.git | |||
| depthai | |||
There was a problem hiding this comment.
I'd prefer having at least this requirement pinned
| @@ -0,0 +1,4 @@ | |||
| depthai==3.0.0 | |||
| depthai-nodes==0.3.4 | |||
There was a problem hiding this comment.
Any specific reason for having such old depthai and depthai-nodes versions?
| @@ -0,0 +1,33 @@ | |||
| identifier = "com.example.m8-controller-box.can-example" | |||
| entrypoint = ["bash", "-c", "/usr/bin/runsvdir -P /etc/service"] | |||
| app_version = "1.0.2" | |||
There was a problem hiding this comment.
Seems strange that we start of with 1.0.2 version instead of 1.0.0 since this is an initial PR for this example
| @@ -0,0 +1,33 @@ | |||
| identifier = "com.example.m8-controller-box.simple-example" | |||
| entrypoint = ["bash", "-c", "/usr/bin/runsvdir -P /etc/service"] | |||
| app_version = "1.0.2" | |||
3 participants
Purpose
new dir for m8-controller-box with overall capabilities and examples to use with OAK4
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable