Merged
Conversation
Eliminated the 'Validate package (dry-run)' step from the release GitHub Actions workflow, streamlining the process before publishing to Hex.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the package validation step from the release workflow, streamlining the publishing process by eliminating the dry-run check before publishing to Hex.
Key Changes
- Removed the "Validate package (dry-run)" step that previously executed
gleam publish --dry-runbefore actual publication
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -98,11 +98,6 @@ jobs: | |||
| git push origin "${TAG}" | |||
| echo "Pushed tag ${TAG} to origin" | |||
|
|
|||
There was a problem hiding this comment.
Removing the dry-run validation step before publishing to Hex eliminates a safety check that could catch package configuration issues or validation errors before attempting actual publication. Consider keeping the dry-run step to prevent failed publishes and ensure package integrity.
Suggested change
| - name: Dry-run publish to Hex | |
| run: | | |
| echo "Validating package with dry-run publish..." | |
| gleam publish --dry-run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminated the 'Validate package (dry-run)' step from the release GitHub Actions workflow, streamlining the process before publishing to Hex.