Conversation
| tag.put("value", normalizeTag(value)); | ||
| tags.add(tag); | ||
| } catch (Exception err) { | ||
| if (shouldLogErrors) { |
There was a problem hiding this comment.
Im not sure why you need this condition? you are logging the error either way
|
|
||
| public abstract OUTPUT doHandleRequest(INPUT input, Context context); | ||
|
|
||
| public void addExecutionTag(String key, String value) { |
There was a problem hiding this comment.
I talked with Harel and we agreed that we dont want to add this here, lets expose those methods from the ExecutionTags class.
| spansContainer.addExecutionTag(key, value); | ||
| } | ||
|
|
||
| public void clearExecutionTags() { |
There was a problem hiding this comment.
I think the only method that should be exposed to the user is AddExecutionTag
nadav3396
left a comment
nadav3396
left a comment
There was a problem hiding this comment.
Good Work, I left you some comments.
Also add some tests please
GuyMoses
left a comment
GuyMoses
left a comment
There was a problem hiding this comment.
please include matching README instructions for users
| rttDuration = null; | ||
| endFunctionSpan = null; | ||
| reporter = null; | ||
| httpSpans = new LinkedList<>(); |
There was a problem hiding this comment.
Why did you add this line?
| } | ||
| } | ||
|
|
||
| public static List<Map<String, String>> getTags() { |
There was a problem hiding this comment.
lets make getTags & clearTags package private methods, I dont want to expose them to users
| return (val == null) ? null : String.valueOf(val); | ||
| } | ||
|
|
||
| public static void addTag(String key, String value, boolean shouldLogErrors) { |
There was a problem hiding this comment.
I dont think we want the shouldLogErrors did you see it in the other tracers?
|
here's an example of execution tags in the node tracer: |
3 participants
No description provided.