Add IEnumerable<T> overloads for collection writers#19
Merged
lukaskabrt merged 4 commits intomasterfrom Jan 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds IEnumerable overloads for all collection writer methods in PbfLite, providing more flexibility for API consumers who want to pass LINQ queries or other enumerable collections without converting to arrays or spans first.
Changes:
- Added IEnumerable overloads for 9 collection writer methods (WriteUIntCollection, WriteULongCollection, WriteIntCollection, WriteLongCollection, WriteSignedIntCollection, WriteSignedLongCollection, WriteBooleanCollection, WriteSingleCollection, WriteDoubleCollection)
- Updated existing tests to explicitly use AsSpan() to disambiguate which overload is being tested
- Bumped package version from 0.4.0 to 0.5.0
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PbfLite/PbfLite.csproj | Version bump from 0.4.0 to 0.5.0 for new minor feature release |
| src/PbfLite/PbfBlockWriter.Collections.cs | Added two private helper methods for IEnumerable collections and 9 public IEnumerable overloads for collection writers |
| src/PbfLite.Tests/PbfBlockWriterTests.Collections.cs | Added test cases for each new IEnumerable overload and updated existing tests to use AsSpan() |
| src/PbfLite.Tests/PbfBlockReaderStreamReaderRoundTripTests.cs | Updated test to use AsSpan() to call specific overload |
| src/PbfLite.Tests/CollectionsRoundTripTests.cs | Updated test to use AsSpan() to call specific overload |
| src/PbfLite.Benchmark/PbfBlockWriterCollectionsBenchmarks.cs | Updated benchmarks to use AsSpan() to ensure they measure specific overload performance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.