Skip to content

Add IEnumerable<T> overloads for collection writers#19

Merged
lukaskabrt merged 4 commits intomasterfrom
feature/write-ienumerable
Jan 11, 2026
Merged

Add IEnumerable<T> overloads for collection writers#19
lukaskabrt merged 4 commits intomasterfrom
feature/write-ienumerable

Conversation

@lukaskabrt
Copy link
Owner

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds IEnumerable overloads for all collection writer methods in PbfLite, providing more flexibility for API consumers who want to pass LINQ queries or other enumerable collections without converting to arrays or spans first.

Changes:

  • Added IEnumerable overloads for 9 collection writer methods (WriteUIntCollection, WriteULongCollection, WriteIntCollection, WriteLongCollection, WriteSignedIntCollection, WriteSignedLongCollection, WriteBooleanCollection, WriteSingleCollection, WriteDoubleCollection)
  • Updated existing tests to explicitly use AsSpan() to disambiguate which overload is being tested
  • Bumped package version from 0.4.0 to 0.5.0

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/PbfLite/PbfLite.csproj Version bump from 0.4.0 to 0.5.0 for new minor feature release
src/PbfLite/PbfBlockWriter.Collections.cs Added two private helper methods for IEnumerable collections and 9 public IEnumerable overloads for collection writers
src/PbfLite.Tests/PbfBlockWriterTests.Collections.cs Added test cases for each new IEnumerable overload and updated existing tests to use AsSpan()
src/PbfLite.Tests/PbfBlockReaderStreamReaderRoundTripTests.cs Updated test to use AsSpan() to call specific overload
src/PbfLite.Tests/CollectionsRoundTripTests.cs Updated test to use AsSpan() to call specific overload
src/PbfLite.Benchmark/PbfBlockWriterCollectionsBenchmarks.cs Updated benchmarks to use AsSpan() to ensure they measure specific overload performance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lukaskabrt and others added 2 commits January 11, 2026 22:07
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@lukaskabrt lukaskabrt merged commit 68c718a into master Jan 11, 2026
1 check passed
@lukaskabrt lukaskabrt deleted the feature/write-ienumerable branch January 11, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants