fix!: change credentials mode from "omit" to "same-origin" when set to false#27
Merged
lukas-reining merged 1 commit intomainfrom Dec 15, 2024
Merged
fix!: change credentials mode from "omit" to "same-origin" when set to false#27lukas-reining merged 1 commit intomainfrom
lukas-reining merged 1 commit intomainfrom
Conversation
lukas-reining
force-pushed
the
fix/credentials-mode
branch
2 times, most recently
from
c535058 to
3e87ce9
Compare
… false Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
fix/credentials-mode
branch
from
3e87ce9 to
3a6183c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default value of the
credentialsoption in fetch.Until now, it was set to
omitif thewithCredentialswas falsy, as @oatkiller pointed out in #26.As per the spec, this value should be
same-siteby default andincludeif thewithCredentialsoption is set totrue.Reference: https://html.spec.whatwg.org/multipage/server-sent-events.html#dom-eventsource-withcredentials-dev
Caution
This is a breaking change, as users with
withCredentialsnot set or set to false, will now send cookies tosame-siteinstead of sending not them.Be sure that this is acceptable for your use case.
Tip
If the
credentialsmode should still be set toomit, you can set theomitCredentialsparameter totrue.If
withCredentialsis also set totrue,omitCredentialswill take precedence.