Skip to content

p5 Brush Assignment: Code Review#1

Open
aaga wants to merge 5 commits intoteachingteamfrom
main
Open

p5 Brush Assignment: Code Review#1
aaga wants to merge 5 commits intoteachingteamfrom
main

Conversation

@aaga
Copy link
Collaborator

@aaga aaga commented Jul 1, 2021

nice brush! see comments below.

Copy link
Collaborator Author

@aaga aaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool concept for a brush! and code looks pretty clean!

let img;
let fun = ['dance', 'play', 'drink', 'sleep', 'fun', 'work', 'school', 'love'];
let food = ['pizza', 'burgers', 'tacos', 'ramen', 'seafood', 'curry', 'wings'];
let drink = ['beer', 'boba', 'coffee', 'tea', 'liquor', 'soda', 'water'];
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these arrays!

}

function preload() {
img = loadImage('./unnamed.png');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, you can name your image files and variables to be more descriptive. e.g. bulbImg = loadImage('./light_bulb.png')

fill(random(colorlist));
ellipse(mouseX, mouseY, 25, 25);
let randomThought;
let test = 'thinking!'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget to remove test code when you're done with it!

else {
randomThought = random(drink);
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the different category of thoughts! It would be cool if it changed the category when you clicked the mouse (instead of having to refresh). Just an idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants