fixed to compile on RHEL 7 based kernels#12
Open
pmcgleenon wants to merge 25 commits intoluigirizzo:masterfrom
Open
fixed to compile on RHEL 7 based kernels#12pmcgleenon wants to merge 25 commits intoluigirizzo:masterfrom
pmcgleenon wants to merge 25 commits intoluigirizzo:masterfrom
Conversation
In change 1d1de89b, nf_queue_entry was refactored, and since v4.0-rc6 some of its member variables have now been extracted to nf_hook_state.
Author
|
RHEL7_NF_BACKPORT is defined in kipfw/Makefile compiles fine for me on RHEL 7.1. a further patch is needed for RHEL 7.2 - the NF hook API has changed there too |
|
@pmcgleenon |
adding support for linux 4.x kernels
Author
|
So it looks like you've got the RHEL 7.2 kernel version. RHEL 7.2 introduced a further change in the NF Hook API. We'll need to make a change similar to #6 for RH7.2 |
|
@pmcgleenon I have fixed the issue for RH7.2. |
Similar change was applied to FreeBSD pfsense/FreeBSD-src@2085b4c#diff-8357b1b1701d22d67098d5b7219e9c6f
Adding license file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the 3.13 kernel version checks aren't sufficient for the NF callback API for RHEL7 based kernels (hooknum is now a const struct nf_hook_ops) rather than int
RHEL7 and later advertises a kernel version 3.10, which has the later version of the NF callback. the vanilla kernel introduced this later than 3.13.
I'm assuming the RHEL clones like CentOS, Oracle, Scientific Linux etc will have the same issue