Skip to content

fixed to compile on RHEL 7 based kernels#12

Open
pmcgleenon wants to merge 25 commits intoluigirizzo:masterfrom
pmcgleenon:master
Open

fixed to compile on RHEL 7 based kernels#12
pmcgleenon wants to merge 25 commits intoluigirizzo:masterfrom
pmcgleenon:master

Conversation

@pmcgleenon
Copy link

the 3.13 kernel version checks aren't sufficient for the NF callback API for RHEL7 based kernels (hooknum is now a const struct nf_hook_ops) rather than int

RHEL7 and later advertises a kernel version 3.10, which has the later version of the NF callback. the vanilla kernel introduced this later than 3.13.

I'm assuming the RHEL clones like CentOS, Oracle, Scientific Linux etc will have the same issue

tomerb and others added 3 commits December 1, 2015 00:50
In change 1d1de89b, nf_queue_entry was refactored, and since v4.0-rc6
some of its member variables have now been extracted to nf_hook_state.
@pmcgleenon
Copy link
Author

RHEL7_NF_BACKPORT is defined in kipfw/Makefile

compiles fine for me on RHEL 7.1. a further patch is needed for RHEL 7.2 - the NF hook API has changed there too

@FS1360472174
Copy link

@pmcgleenon
you have added the condition RHEL7.but still got error about the define of call_ipfw.
which call at ipfw2_mod.c line 848.
I test on linux-3.10.0-327.4.5.el7.so how to fix it?

adding support for linux 4.x kernels
@pmcgleenon
Copy link
Author

So it looks like you've got the RHEL 7.2 kernel version. RHEL 7.2 introduced a further change in the NF Hook API. We'll need to make a change similar to #6 for RH7.2

@FS1360472174
Copy link

FS1360472174 commented May 7, 2016

@pmcgleenon I have fixed the issue for RH7.2.
actually I dislike adding so many linux version condition on Hook type define.
we need to note that.as I mention at #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants