[fix] Add spinner during worktree removal in clean command (#91)#95
Merged
lugassawan merged 1 commit intomainfrom Mar 11, 2026
Merged
[fix] Add spinner during worktree removal in clean command (#91)#95lugassawan merged 1 commit intomainfrom
lugassawan merged 1 commit intomainfrom
Conversation
The spinner was stopped after analysis and never restarted for the removal phase, causing s.Update() progress messages to be silently dropped. Restart the spinner before RemoveCandidates in both cleanMerged and cleanStale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoveCandidatesin bothcleanMergedandcleanStaleso progress messages are displayed during the removal phases.Update()calls were silently dropped because the spinner was stopped after analysis and never restartedCloses #91
Test plan
make fmt— cleanmake lint— 0 issuesmake test— all pass