[fix] Improve error handling across operations#90
Merged
lugassawan merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
…bounds - Propagate ListWorktrees error in PostCreateSetup instead of silently discarding - Add max iteration cap (1000) to duplicate command suffix loop - Surface squash-merge and stale-check errors as warnings in clean operations - Add Error field to CleanedItem for per-item failure visibility - Improve AheadBehind variable naming for maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListWorktreeserror inPostCreateSetupinstead of silently discarding — affectsadd,duplicate, andrestorecommandsgit rev-parsecallsMergedResult/StaleResulttypes withWarnings []stringErrorfield toCleanedItemfor per-item failure visibility inRemoveCandidatesAheadBehindvariable naming from cryptica, bto using named returnsahead, behinddirectlyN/A
Test Plan
make fmt— cleanmake lint— 0 issuesmake test— 1081/1081 passrimba duplicatewith--asand auto-suffixrimba clean --mergedandrimba clean --staleshow warnings when branches are skipped