Skip to content

[fix] Fix spinner lifecycle in add and merge commands (#88)#89

Merged
lugassawan merged 1 commit intomainfrom
fix/add-output-formatting
Feb 24, 2026
Merged

[fix] Fix spinner lifecycle in add and merge commands (#88)#89
lugassawan merged 1 commit intomainfrom
fix/add-output-formatting

Conversation

@lugassawan
Copy link
Owner

@lugassawan lugassawan commented Feb 24, 2026

Summary

  • Fix missing s.Stop() before output in add and merge commands, causing result text to appear on the same line as the spinner
  • Change progress callback from s.Start(msg) to s.Update(msg) so all progress steps are visible (especially in non-animated/CI mode)
  • Add explicit s.Start() before operations to match the correct pattern used in duplicate and restore commands

Closes #88

Test Plan

  • make fmt — clean
  • make lint — 0 issues
  • make test — 19/19 packages pass
  • Manual: rimba add test-task shows step-by-step spinner updates and "Created" on a new line

@lugassawan lugassawan merged commit cb56475 into main Feb 24, 2026
6 checks passed
@lugassawan lugassawan deleted the fix/add-output-formatting branch February 24, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI output formatting issues in rimba add command

1 participant