Skip to content

fix: remove broken Search button from sidebar#147

Merged
lugassawan merged 1 commit intomainfrom
fix/remove-sidebar-search-button
Mar 12, 2026
Merged

fix: remove broken Search button from sidebar#147
lugassawan merged 1 commit intomainfrom
fix/remove-sidebar-search-button

Conversation

@lugassawan
Copy link
Owner

@lugassawan lugassawan commented Mar 12, 2026

Issue

N/A

Summary

  • Remove the Search button from the sidebar that was added in PR feat: keyboard shortcuts system with help overlay #139 — it had mismatched styling (text-xs py-2 vs nav items' text-sm py-3) and duplicates functionality already available via Cmd+K and "/" keyboard shortcuts
  • Clean up onToggleCommandPalette prop from Sidebar component and App usage
  • Remove unused nav.search i18n key from en.json and id.json
  • Update tests to reflect the removal (button count 13→12, remove search-related assertions and mock keys)

Test Plan

  • make lint passes — 0 issues
  • make test-frontend passes — 84 files, 567 tests
  • make dev — sidebar no longer shows Search button above Settings
  • Cmd+K still opens command palette
  • "/" still opens command palette
  • Settings button still works

Notes

The Search icon import in Sidebar.svelte is retained — it's used by the "Stock Lookup" nav item, not the removed search button.

The Search button added in PR #139 had mismatched styling (text-xs py-2
vs nav items' text-sm py-3). Rather than fixing styling, remove it
entirely — Cmd+K and "/" shortcuts are sufficient for opening the
command palette.
@lugassawan lugassawan merged commit f5fa605 into main Mar 12, 2026
10 checks passed
@lugassawan lugassawan deleted the fix/remove-sidebar-search-button branch March 12, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant