Skip to content

First guess at update to 9.3.x Totally untested#1

Open
gregw wants to merge 2 commits intoludoch:masterfrom
webtide:master
Open

First guess at update to 9.3.x Totally untested#1
gregw wants to merge 2 commits intoludoch:masterfrom
webtide:master

Conversation

@gregw
Copy link

@gregw gregw commented Dec 29, 2015

Just in case you are in a hurry, here is a very quick guess at what the port will look like.
Totally not tested and probably broken in lots of ways.... but if you want to progress, it may be worth a try.

I'll look more tomorrow.

@ludoch
Copy link
Owner

ludoch commented Dec 29, 2015

Thanks Greg!
One issue I see is that MetaData.Response info is null on the send call:

java.lang.NullPointerException
at com.google.apphosting.runtime.jetty9.RpcConnection.send(RpcConnection.java:264)
at org.eclipse.jetty.server.HttpChannel.sendResponse(HttpChannel.java:673)
at org.eclipse.jetty.server.HttpChannel.write(HttpChannel.java:722)
at org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:177)
at org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:163)
at org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:413)
at com.google.apphosting.tests.usercode.testservlets.ServletContextResourceServlet.doGet(ServletContextResourceServlet.java:26)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:618)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:821)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1685)
at com.google.apphosting.utils.servlet.ParseBlobUploadFilter.doFilter(ParseBlobUploadFilter.java:125)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)
at com.google.apphosting.runtime.jetty9.SaveSessionFilter.doFilter(SaveSessionFilter.java:37)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)
at com.google.apphosting.utils.servlet.JdbcMySqlConnectionCleanupFilter.doFilter(JdbcMySqlConnectionCleanupFilter.java:60)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)

On Mon, Dec 28, 2015 at 4:56 PM, Greg Wilkins notifications@github.com
wrote:

Just in case you are in a hurry, here is a very quick guess at what the
port will look like.
Totally not tested and probably broken in lots of ways.... but if you want
to progress, it may be worth a try.

I'll look more tomorrow.

You can view, comment on, or merge this pull request online at:

#1
Commit Summary

  • First guess at update to 9.3.x Totally untested

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1.

@ludoch
Copy link
Owner

ludoch commented Dec 29, 2015

Which is not really used, so I'll remove its usage:-) Stay tune.

On Tue, Dec 29, 2015 at 8:59 AM, Ludovic Champenois <
ludovic.champenois@gmail.com> wrote:

Thanks Greg!
One issue I see is that MetaData.Response info is null on the send call:

java.lang.NullPointerException
at com.google.apphosting.runtime.jetty9.RpcConnection.send(RpcConnection.java:264)
at org.eclipse.jetty.server.HttpChannel.sendResponse(HttpChannel.java:673)
at org.eclipse.jetty.server.HttpChannel.write(HttpChannel.java:722)
at org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:177)
at org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:163)
at org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:413)
at com.google.apphosting.tests.usercode.testservlets.ServletContextResourceServlet.doGet(ServletContextResourceServlet.java:26)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:618)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:821)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1685)
at com.google.apphosting.utils.servlet.ParseBlobUploadFilter.doFilter(ParseBlobUploadFilter.java:125)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)
at com.google.apphosting.runtime.jetty9.SaveSessionFilter.doFilter(SaveSessionFilter.java:37)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)
at com.google.apphosting.utils.servlet.JdbcMySqlConnectionCleanupFilter.doFilter(JdbcMySqlConnectionCleanupFilter.java:60)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)

On Mon, Dec 28, 2015 at 4:56 PM, Greg Wilkins notifications@github.com
wrote:

Just in case you are in a hurry, here is a very quick guess at what the
port will look like.
Totally not tested and probably broken in lots of ways.... but if you
want to progress, it may be worth a try.

I'll look more tomorrow.

You can view, comment on, or merge this pull request online at:

#1
Commit Summary

  • First guess at update to 9.3.x Totally untested

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1.

@gregw
Copy link
Author

gregw commented Dec 30, 2015

You probably worked this out, but the info passed to that send is only non-null on the first call when it commits the response. Subsequent calls can occur with just data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants