Allow passing arbitrary arguments for attributes to svg inliner #2006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Makes it possible to add arbitrary attributes to inline SVGs.
Description
More than often I need to add attributes to inline SVGs, especially with ARIA, and sometimes class names or data attributes. Until now I've been adding them manually to the SVG source files, but it's easy to lose oversight and forget adding some attributes (like
aria-hiddenfor example).This PR makes it possible to add arbitrary attributes to the SVG tag:
It also still works with the strip styling flag:
Finally something I wanted to add for a long time already, allowing to pass the file path without the extension:
Checklist
crystal tool format spec src./script/setup./script/test