Feature/per action body size limit #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability for individual actions to override the global MaximumRequestSizeHandler limit using the `set_request_body_limit` macro. This allows actions that need to handle larger or smaller request bodies to customize their limits without affecting other actions. Includes comprehensive tests and CHANGELOG entry.
jwoertink
requested changes
Nov 8, 2025
Member
jwoertink
left a comment
jwoertink
left a comment
There was a problem hiding this comment.
Nice! I think this could come in handy. I just noticed a few small things.
watzon
commented
Nov 8, 2025
| end | ||
| end | ||
|
|
||
| private def find_matching_action(context : HTTP::Server::Context) |
Member
There was a problem hiding this comment.
ah, nice. Yeah, I think this works better.
jwoertink
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the ability for individual actions to override the global MaximumRequestSizeHandler limit using the
set_request_body_limitmacro. This allows actions that need to handle larger or smaller request bodies to customize their limits without affecting other actions.Closes #1989
Checklist
crystal tool format spec src./script/setup./script/test