Refactor how credentials works to be a bit more agnostic #1135
+83
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #415
This PR starts the work to make Avram a little more agnostic. Supporting alternate DBs like MySQL, or SQLite would still present a very hefty challenge since there's not a lot of people that contribute to this library, and I only use postgres. However, we've already had a few issues where CockroachDB differs from postgres even though it's uses the postgres protocol. With this change, we can now at least do something like
A ton of things would need massive refactoring and thought before trying to support any non-postgres related DB like the
PG.connect_listenor usingPQ::Notification, etc.. I'll worry about those later.For now, the big benefit is
Avram::Credentialsis now just a thing wrapper aroundURIso we no longer need to handle complex building logic.