feat: Add insertion optimization and per-index memory attribution#7
Merged
feat: Add insertion optimization and per-index memory attribution#7
Conversation
Insertion Performance: - Unified data record persistence in insertHere() (was duplicated in basicInsert/split) - Added cache lookup fast path in _insert() when eviction disabled - Fixed propagateMBRUpdate() clearing cache pointer via setKeyOwned() Per-Index Memory: - Added FieldMemoryStats and per-field tracking to MappingManager - Added IndexMemoryStats and printMemoryBreakdown() to IndexDetails - Pass field_name through SegmentAllocator for file-to-field registration Test Fixes: - Fixed double-delete in test_xtree.cpp (cache owns mock objects) - Fixed use-after-free in test_performance.cpp (removed clearCache before delete) Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insertion Performance:
Per-Index Memory:
Test Fixes: