feat: Add cache ownership tracking and lazy segment remapping#6
Merged
Conversation
- Add `owns_object` flag to LRUCacheNode for LRUDeleteObject policy
- Only delete objects when owns_object=true (heap-allocated)
- Prevents undefined behavior when caching mmap'd memory
- Add `add(id, object, owns_object)` overloads to LRUCache and ShardedLRUCache
- Add `lookup_or_attach(key, record, owns_object)` overload to ShardedLRUCache
- Implement lazy segment remapping in SegmentAllocator
- Release pins when segments are not actively accessed
- Re-map on demand with thread-safe locking
- Add release_cold_pins() for proactive memory release
- Add SegmentAllocator destructor to properly release pins on shutdown
- Add ServerlessFieldScaling test (100 fields, bounded 4GB mmap)
Test results: 100 fields with 81 MB RSS, 3.84 GB mmap (bounded), 0 crashes
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
owns_objectflag to LRUCacheNode for LRUDeleteObject policyadd(id, object, owns_object)overloads to LRUCache and ShardedLRUCachelookup_or_attach(key, record, owns_object)overload to ShardedLRUCacheTest results: 100 fields with 81 MB RSS, 3.84 GB mmap (bounded), 0 crashes