Align local benchmark skill levels with CI#45
Merged
Conversation
Change local benchmark default from skill levels 1-5 to 3-4-5 to match the CI workflow. Also add scripts/** to the benchmark CI path trigger so workflow changes are tested automatically.
Greptile OverviewGreptile SummaryThis PR makes local benchmarking match the CI benchmark configuration by narrowing the default Stockfish skill levels in I didn’t find any issues that need fixing before merge in the touched files; both changes are minimal and consistent with the stated intent. Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .github/workflows/benchmark.yml | Adds 'scripts/**' to the workflow path filter so benchmark CI runs when benchmark scripts change; change is syntactically valid and matches intent. |
| scripts/benchmark.sh | Changes default SKILL_LEVELS from '1 2 3 4 5' to '3 4 5' to align with CI; keeps env override behavior intact. |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Git as GitHub
participant GA as GitHub Actions
participant Script as scripts/benchmark.sh
Dev->>Git: Push changes to PR
Git-->>GA: Trigger workflow (paths include moonfish/**, opening_book/**, scripts/**, pyproject.toml, requirements.txt)
GA->>Script: Run benchmark script
Script-->>GA: Uses default SKILL_LEVELS="3 4 5" (unless overridden by env)
GA-->>Git: Publish benchmark job result
🔬 Stockfish Benchmark Resultsvs Stockfish Skill Level 3
Non-checkmate endings:
vs Stockfish Skill Level 4
Non-checkmate endings:
vs Stockfish Skill Level 5
Non-checkmate endings:
Configuration
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1 2 3 4 5to3 4 5to match CI configurationscripts/**to benchmark CI path trigger so script changes trigger the workflowTest plan
scripts/**path is now included)