Open
Conversation
lucacorti
commented
Feb 6, 2024
7d77354 to
2ff8522
Compare
ce7a9c6 to
f086f47
Compare
3e7d27c to
5b49569
Compare
Collaborator
|
It looks good. If I'm reading it correctly with this validation step this library can validate the params itself without any other library doing the job. |
Owner
Author
|
Yes, that's the idea. This is just a POC:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a POC to see if we can easily add validation by extending resource attributes and leveraging JSON Schema to do the heavy lifting. What do you think?