34 feature02 supervisor actor #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 188 191 +3
===========================================
Files 18 19 +1
Lines 699 731 +32
Branches 37 39 +2
===========================================
+ Hits 699 731 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…or-actor # Conflicts: # app/actors/SupervisorActor.java # app/actors/UserActor.java
daracula
reviewed
Nov 30, 2025
Comment on lines
+158
to
+175
| // static class QueryInfo { | ||
| // /** The Search model object containing query parameters and fetched results */ | ||
| // final Search search; | ||
| // | ||
| // /** Set of UserActors watching this query and expecting updates */ | ||
| // final Set<ActorRef<UserActor.Message>> watchers = new HashSet<>(); | ||
| // | ||
| // /** | ||
| // * Constructs a new QueryInfo with the specified parameters. | ||
| // * @author Luan Tran | ||
| // * @param query the search query string | ||
| // * @param sortBy the sort order for results | ||
| // * @param apiKey the News API key | ||
| // */ | ||
| // QueryInfo(String query, String sortBy, String apiKey) { | ||
| // this.search = new Search(query, sortBy, apiKey); | ||
| // } | ||
| // } |
Collaborator
Author
There was a problem hiding this comment.
Yes, just after Luan review this part
luantran
approved these changes
Nov 30, 2025
|
|
||
| pushUpdatesToClient(); | ||
| // After readability is computed, ask SentimentAnalyzerActor to score the latest search | ||
| if (!searchHistory.isEmpty()) { |
Owner
There was a problem hiding this comment.
Why is sentiment analysis being done in readability results?? This works, ill approve it because of lack of time but this absolutely should not be here
| latest.setSentiment(":-|"); | ||
| pushUpdatesToClient(); | ||
| } else { | ||
| AskPattern.ask( |
Owner
There was a problem hiding this comment.
Since both are actors, you should be using tell, not ask, but ok
| * Wrapper that holds a Search object and its watchers. | ||
| * @author Luan Tran | ||
| */ | ||
| // static class QueryInfo { |
| * @return Behaviors.same() to continue with the same behavior | ||
| */ | ||
| private Behavior<Message> onFetchTick(FetchTick msg) { | ||
| /*private Behavior<Message> onFetchTick(FetchTick msg) { |
daracula
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a supervisor actror, and a sentiment analyzer actor.