Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

[WIP] Implement cross-platform support with TCP fallback #8

Merged
observerw merged 3 commits into from
Jan 12, 2026
Merged

[WIP] Implement cross-platform support with TCP fallback #8

observerw merged 3 commits into from
Jan 12, 2026

Conversation

Copy link
Contributor

Copilot AI commented Jan 12, 2026 •
edited
Loading

  • Add directory creation for MANAGER_CONN_PATH.parent on Windows in main.py
  • Fix taskkill filter syntax in test_cli_integration.py (Windows process killing)
  • Add documentation for security model (TCP on 127.0.0.1 without authentication)
  • Add logic to fail fast on Windows when only uds_path is provided in wait_for_server
  • Add documentation for ConnectionInfo.url fallback behavior
  • Fix resource leak by properly closing httpx.AsyncClient in ManagerServer
  • Address race condition in port allocation in main.py
  • Address race condition in port allocation in client.py
  • Add error handling for _load_connection_info in test_server_management.py
  • Add validation for self._port being None before accessing in client.py
  • Extract port allocation logic into a utility function
  • Make exception handling more specific in manager/init.py
  • Make exception handling more specific in test_server_management.py
  • Add explanatory comments for empty except clauses
  • Close socket properly in ManagedClient on Windows
  • Add error handling for WMIC command in tests (deprecated on newer Windows)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 12, 2026
Open
Copilot AI and others added 2 commits January 12, 2026 07:16
@observerw
fix: address review comments for cross-platform support
f773afc 
- Add directory creation for MANAGER_CONN_PATH.parent on Windows
- Fix Windows process killing in tests (use WMIC instead of invalid taskkill filter)
- Add comprehensive security documentation for TCP connections
- Add fast-fail logic for unsupported UDS on Windows
- Document ConnectionInfo.url fallback behavior
- Fix resource leak by properly closing httpx.AsyncClient in ManagerServer
- Extract port allocation into reusable utility function
- Address race conditions by passing socket fd to uvicorn
- Add port validation in ManagedClient.conn property
- Make exception handling more specific with explanatory comments
- Add proper error handling in test helpers

Co-authored-by: observerw <20661574+observerw@users.noreply.github.com>
@observerw
fix: address code review feedback on resource management
afcc8c3 
- Close socket properly in ManagedClient cleanup on Windows
- Add error handling for WMIC command (deprecated in newer Windows)
- Add PowerShell fallback for process termination in tests

Co-authored-by: observerw <20661574+observerw@users.noreply.github.com>
@observerw observerw marked this pull request as ready for review January 12, 2026 07:19
@observerw observerw merged commit c649c07 into feat/cross-platform-support Jan 12, 2026
@observerw observerw deleted the copilot/sub-pr-7 branch January 12, 2026 07:20
Copilot AI requested a review from observerw January 12, 2026 07:20
Copilot stopped work on behalf of observerw due to an error January 12, 2026 07:20
The session was cancelled by the user.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@observerw observerw Awaiting requested review from observerw

Assignees

@observerw observerw

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@observerw