fix: correct BFS path-finding in Relation API and add integration tests#17
Merged
observerw merged 3 commits intofeat/add-relation-apifrom Jan 10, 2026
Merged
fix: correct BFS path-finding in Relation API and add integration tests#17observerw merged 3 commits intofeat/add-relation-apifrom
observerw merged 3 commits intofeat/add-relation-apifrom
Conversation
- Fix documentation: Remove incorrect max_depth field from RelationResponse - Fix BFS bug: Move target check before visited.add() to find all paths - Fix BFS optimization: Check visited before adding to queue Co-authored-by: observerw <20661574+observerw@users.noreply.github.com>
- Add mock LSP client with call hierarchy and document symbol support - Test single path discovery - Test multiple paths between symbols - Test scenario with no path - Test max_depth boundary conditions - Test cycle detection with recursive calls - Test direct calls - Test paths of different lengths Co-authored-by: observerw <20661574+observerw@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add Relation API support to trace call paths
fix: correct BFS path-finding in Relation API and add integration tests
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses bugs in the Relation API BFS implementation that prevented discovering all paths between symbols and caused inefficient queue management.
Fixes
BFS path discovery bug: Target check now executes before marking nodes as visited. Previously, the first path to reach the target would mark it visited, blocking discovery of alternate paths.
BFS memory optimization: Nodes are checked for visited status before queue insertion, preventing redundant entries in graphs with high fan-out.
Documentation: Removed incorrect
max_depthfield from RelationResponse schema table (accessible viarequest.max_depth).Tests
Added 7 integration tests with mock LSP client:
All 19 tests pass; CodeQL reports 0 alerts.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.