store-sqlite: treat substring queries as literals#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context/problem
search_substring()builds a SQLLIKEpattern directly from user text. Queries containing_or%are interpreted as wildcards, so literal searches (for examplehello_world) can match unrelated messages (likehelloxworld). This makes fallback search results noisy and unpredictable.exact change
escape_like_pattern()incrates/store-sqlite/src/lib.rsto escape%,_, and\in user queries.search_substring()to use the escaped pattern andESCAPE '\\'in SQL.substring_search_escapes_like_wildcardsto verifyhello_worldmatches literal underscore content only.validation steps
cargo fmt --all --checkcargo test -p store-sqlitecargo clippy --workspace --all-targets -- -D warningscargo test --workspaceAll commands passed locally.
rollback notes
Revert commit
3122ce2to restore previous behavior where%and_act as SQL wildcards in substring fallback search.