Feature/on demand thumbnails pyav #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add signal handlers (SIGINT, SIGTERM) for graceful shutdown - Implement FilteredStderr class to suppress harmless cleanup errors - Improve shutdown handling with proper try/except/finally blocks - These errors occur in cheroot's makefile cleanup during garbage collection and are harmless but noisy
- Replace ffmpeg-python with PyAV for video property extraction and frame decoding in main.py. - Implement a new thumbnail generation endpoint in the Viewer class to allow for dynamic thumbnail creation at specified timestamps. - Update dependencies in pyproject.toml and requirements.txt to reflect the removal of ffmpeg-python and the addition of PyAV installation instructions. - Introduce a custom JavaScript player for enhanced video controls and thumbnail previews. - Update tests to mock PyAV functionality instead of ffmpeg, ensuring compatibility with the new video processing approach.
- Introduce a step in the CI workflow to make system Python packages available by updating the PYTHONPATH. - Verify the importability of the PyAV module to ensure proper setup for video processing tasks.
- Remove the matrix strategy for Python versions and directly set up Python 3. - Install python3-pip and python3-venv alongside python3-av for enhanced functionality. - Update commands to use python3 for installing dependencies and running tests. - Replace the step for making system Python packages available with a direct verification of the PyAV module import.
- Enhance the mocking of database connections in the TestUpdateThumbnails class to handle multiple calls during Viewer initialization and thumbnail updates. - Implement side effects for mock cursor execution to simulate SELECT and INSERT queries. - Add a new mock connection handling mechanism to differentiate between initial and subsequent database interactions. - Update test cases to ensure proper functionality with the new mocking strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.