DomainDecomposition memoryleak fix #393
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the DomainDecomposition constructor, initMPIGridDims is executed, creating a new communicator with topology information.
When the function DomainDecomposition::readXML is executed, initMPIGridDims is executed a second time, creating another communicator. Since the original communicator is never released, this results in a memory leak.
To fix the problem, a variable was created that indicates whether a communicator has already been created. If this is the case, the previous communicator is then deleted.
Related Pull Requests
none
Resolved Issues
none
How Has This Been Tested?
The program was tested both in cases where initMPIGridDims was executed a second time and in cases where this did not happen, with test code inserted to ensure that the communicator is now created and released correctly.
Documentation