New collcommobj #329
Open
New collcommobj #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where possible an ifdef was added. So, depending on the cmake flag for ENABLE_PERSISTENT, the code is compiled differently.
Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
…onfig Move cmake configuration for persistent collectives into the mpi module
This updated wrapper has an improved interface and is more compact due to the environment class being internal.
This function does not clear the forces in the SoA structure.
This reverts commit 4ba2dff.
This reverts commit 813b6ec.
This reverts commit 3adc768.
FG-TUM
requested changes
Jan 14, 2025
Member
FG-TUM
left a comment
FG-TUM
left a comment
There was a problem hiding this comment.
Impressive template magic :D
Can you explain in the main text of the PR why all of this is "just" behind an ifdef and why we can't simply get rid of the old communicator class?
Previously it was named Coll_Comm_Obj, but most of ls1 follows camel case, so the name was adjusted.
The CollectiveCommunicationPersistent.h and CollectiveCommunicationPersistent_helper.h will now always be included, if ENABLE_MPI is set. This was done to get rid of the ifdef-endif blocks enclosing all collective communication calls. The ENABLE_PERSISTENT was moved inside the CollCommObj class to determine if a persistent collective communication call is to be used. The implementation of CollCommObj also changed because of that. Now the persistent collective and the normal collective functions share exactly the same interface with the only difference being the ENABLE_PERSISTENT determining which is used. The new communicate() functions now start all types of collective communication, therefore is it no longer possible to omit the collective function type at construction and give it during communication.
The function now returns a tuple of the received data. This change makes it obvious that data is returned from this function. Another advantage is that with structured bindings (C++ 17) the returned tuple can be used to declare the variables into which the tuple values should be copied (see docu in CollectiveCommunicationPersistent.h for more detail).
This was done to match the style of the rest of the code.
The Deallocator class was replaced with the MPI_Environment class which wraps the MPI_Init, MPI_Init_thread and MPI_Finalize functions. This new approach to control the destruction of the static data members is more concise than the previous approach.
These functions were used to create a CollCommObj, but make little sense to use. So, they were removed.
The template argument was not necessary for the template deductions and was replaced with a normal constructor argument. The mutex data member was also removed.
Update to the documentation concerning recent commits. The code formatting was also updated to be in line with javadoc style and the rest of the code.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| numMolecules = domainDecomp->collCommGetUnsLong(); | ||
| rotDOF = domainDecomp->collCommGetUnsLong(); | ||
| domainDecomp->collCommFinalize(); | ||
| auto collComm = makeCollCommObjAllreduceAdd(domainDecomp->getCommunicator(), summv2, sumIw2, numMolecules, rotDOF); |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
| for(int d=0; d < 3; d++) sigv[d] = domainDecomp->collCommGetDouble(); | ||
| domainDecomp->collCommFinalize(); | ||
|
|
||
| auto collComm = makeCollCommObjAllreduceAdd(domainDecomp->getCommunicator(), sigv[0], sigv[1], sigv[2]); |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
This should get rid an error occurring with the static variables.
Added a fake getCommunicator function in DomainDecompBase.h. Added a FakeCollCommObj which does nothing but satisfies the interface of the non-fake object. Also added creation functions for the fake object that match the non-fake ones.
Previously the MPI communicator was stored as a separate member, but it is now part of the MPI_Members member. This was done because it makes code clearer to store members with similar usage together. There was a check added to the CollCommObj constructor that checks, if the given communicator has been changed (this is especially important to pass all tests). The MPI_Members members has been reverted to a pointer. This was done to fix the MPI_x_free after MPI_Finalize issue.
# Conflicts: # tools/gui/generators/CubicGridGenerator.cpp # tools/gui/generators/RayleighTaylorGenerator.cpp
Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
cniethammer
previously approved these changes
Feb 25, 2025
Contributor
cniethammer
left a comment
cniethammer
left a comment
There was a problem hiding this comment.
Just some minor suggestions to be included.
LGTM
Co-authored-by: Christoph Niethammer <cniethammer@users.noreply.github.com>
Co-authored-by: Christoph Niethammer <cniethammer@users.noreply.github.com>
Co-authored-by: Christoph Niethammer <cniethammer@users.noreply.github.com>
Co-authored-by: Christoph Niethammer <cniethammer@users.noreply.github.com>
Co-authored-by: Christoph Niethammer <cniethammer@users.noreply.github.com>
Co-authored-by: Christoph Niethammer <cniethammer@users.noreply.github.com>
…nto new_collcommobj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented persistent communication class. This class can also be used to replace most of the already present collective communication in the code.
Related Pull Requests
Resolved Issues
How Has This Been Tested?
Tested with Spinodal Decomposition example and unit tests.